Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update jest monorepo to v29.4.3 #7651

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix(deps): update jest monorepo to v29.4.3 #7651

merged 3 commits into from
Mar 2, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 16, 2023 •
edited by jtoar
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
babel-jest 29.4.2 -> 29.4.3 age adoption passing confidence
jest (source) 29.4.2 -> 29.4.3 age adoption passing confidence
jest-environment-jsdom 29.4.2 -> 29.4.3 age adoption passing confidence

Release Notes

facebook/jest

v29.4.3

Compare Source

Features
  • [expect] Update toThrow() to be able to use error causes (#​13606)
  • [jest-core] allow to use workerIdleMemoryLimit with only 1 worker or runInBand option (#​13846)
  • [jest-message-util] Add support for error causes (#​13868 & #​13912)
  • [jest-runtime] Revert import assertions for JSON modules as it's been relegated to Stage 2 (#​13911)
Fixes
  • [@jest/expect-utils] subsetEquality should consider also an object's inherited string keys (#​13824)
  • [jest-mock] Clear mock state when jest.restoreAllMocks() is called (#​13867)
  • [jest-mock] Prevent mockImplementationOnce and mockReturnValueOnce bleeding into withImplementation (#​13888)
  • [jest-mock] Do not restore mocks when jest.resetAllMocks() is called (#​13866)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the release:chore This PR is a chore (means nothing for users) label Feb 16, 2023
@renovate renovate bot assigned jtoar Feb 16, 2023
@replay-io
Copy link

replay-io bot commented Feb 16, 2023 •
edited
Loading

16 replays were recorded for 848e582.

image 0 Failed
image 16 Passed
    requireAuth graphql checks 
          ```
    locator.waitFor: Target closed
    =========================== logs ===========================
    waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
    ============================================================
    ```
  </ol>
</details>
<li><a href=https://app.replay.io/recording/84edd176-803e-40af-8a62-a63e64e25c41>useAuth hook, auth redirects checks</a></li>
<li><a href=https://app.replay.io/recording/b3e26dac-4ff2-44a1-a6db-e297fddfc5e3>Check that <meta> tags are rendering the correct dynamic data</a></li>
<li><a href=https://app.replay.io/recording/eed3d5c3-6607-4d19-a9f9-a66f33fe8fc3>Check that a specific blog post is prerendered</a></li>
<li><a href=https://app.replay.io/recording/32292562-b621-4305-8490-ba4156642970>Check that about is prerendered</a></li>
<li><a href=https://app.replay.io/recording/6f29232b-101c-40e4-880f-861139ceab96>Check that homepage is prerendered</a></li>
<li><a href=https://app.replay.io/recording/ed34e52e-ab4d-4ffd-98fc-4ecf89f1095e>Check that you can navigate from home page to specific blog post</a></li>
<li><a href=https://app.replay.io/recording/1737e9a5-c111-42cb-a6cb-12ddf7e3b58b>Waterfall prerendering (nested cells)</a></li>
<li><a href=https://app.replay.io/recording/51ee1573-d251-4ae9-b8b5-92b26a834255>RBAC: Admin user should be able to delete contacts</a></li>
<li><a href=https://app.replay.io/recording/aa16e33e-8e74-488f-b0b1-aeed8153229c>RBAC: Should not be able to delete contact as non-admin user</a></li>
<li><a href=https://app.replay.io/recording/e611ae19-5ca6-482c-a16f-f3c5de0e1eda>Smoke test with dev server</a></li>
<li><a href=https://app.replay.io/recording/d1165f91-da81-4926-9ad9-c24ccbce2557>Smoke test with rw serve</a></li>
<li><a href=https://app.replay.io/recording/7443fa8a-cb7b-4a9a-ab79-c2b19b9bf286>Loads Cell mocks when Cell is nested in another story</a></li>
<li><a href=https://app.replay.io/recording/289ee8fc-e3b2-4f36-84f8-cd34eae31a30>Loads Cell Stories</a></li>
<li><a href=https://app.replay.io/recording/b8cf88aa-e9a3-4dc7-a1d9-4d509a8e5b49>Loads MDX Stories</a></li>
<li><a href=https://app.replay.io/recording/d8922c2c-d2a6-41eb-9b95-7bd5fae8bbc9>Mocks current user, and updates UI while dev server is running</a></li>

View test run on Replay ↗︎

@renovate renovate bot force-pushed the renovate/jest-monorepo branch 4 times, most recently from 8d17476 to 5eb78a4 Compare February 17, 2023 19:40
@jtoar jtoar added the fixture-ok Override the test project fixture check label Feb 22, 2023
@renovate renovate bot force-pushed the renovate/jest-monorepo branch 21 times, most recently from 85b6849 to f5bddd4 Compare March 1, 2023 03:41
@renovate renovate bot force-pushed the renovate/jest-monorepo branch from f5bddd4 to 47bab95 Compare March 1, 2023 04:47
@renovate renovate bot force-pushed the renovate/jest-monorepo branch 13 times, most recently from b9d3e3c to 8c71957 Compare March 1, 2023 22:46
@thedavidprice
Copy link
Contributor

thedavidprice commented Mar 1, 2023 •
edited
Loading

There was a "fix" that changed the behavior of jest.restoreAllMocks(). If tests are failing, most likely restore..() will need to be replaced with jest.resetAllMocks(). See:

@jtoar it's likely that other users are going to run into this as well. Let's include this in the next minor but call out the "fix" plus links in the Release Notes.

@renovate renovate bot force-pushed the renovate/jest-monorepo branch 2 times, most recently from 77d2654 to 116d01a Compare March 1, 2023 23:36
@jtoar jtoar added release:breaking This PR is a breaking change and removed release:chore This PR is a chore (means nothing for users) labels Mar 2, 2023
@renovate renovate bot force-pushed the renovate/jest-monorepo branch from 9c33e0b to 3b1f8fa Compare March 2, 2023 00:13
@renovate
Copy link
Contributor Author

renovate bot commented Mar 2, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@jtoar jtoar merged commit 4d8f0a8 into main Mar 2, 2023
@jtoar jtoar deleted the renovate/jest-monorepo branch March 2, 2023 01:06
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 2, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Mar 2, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Mar 7, 2023
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/vite-ssr
911522e 
* 'main' of github.com:redwoodjs/redwood: (50 commits)
  Use formatCacheKey() when deleting a key (redwoodjs#7362)
  fix(deps): update dependency @types/node to v16.18.14 (redwoodjs#7739)
  chore(deps): update dependency @npmcli/arborist to v6.2.4 (redwoodjs#7741)
  chore(deps): update dependency @replayio/playwright to v0.3.24 (redwoodjs#7738)
  chore(deps): update dependency @testing-library/react to v14 (redwoodjs#7737)
  chore(deps): update dependency @testing-library/dom to v9 (redwoodjs#7736)
  chore(deps): update dependency @types/vscode to v1.76.0 (redwoodjs#7729)
  chore(deps): update dependency zx to v7.2.0 (redwoodjs#7731)
  fix(deps): update dependency webpack-bundle-analyzer to v4.8.0 (redwoodjs#7735)
  fix(deps): update dependency babel-plugin-polyfill-corejs3 to v0.7.1 (redwoodjs#7732)
  fix(deps): update dependency msw to v1.1.0 (redwoodjs#7733)
  chore(deps): update dependency @clerk/clerk-react to v4.12.0 (redwoodjs#7728)
  fix(deps): update dependency @types/node to v16.18.13 (redwoodjs#7727)
  fix: change isDataEmpty, add codemod, fix codemod (redwoodjs#7704)
  fix: avoid naming conflict with `client` prop (redwoodjs#7024)
  fix(deps): update jest monorepo to v29.4.3 (redwoodjs#7651)
  chore(deps): update dependency @auth0/auth0-spa-js to v2 (redwoodjs#7524)
  fix(deps): update dependency @types/aws-lambda to v8.10.111 (redwoodjs#7726)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.7.7 (redwoodjs#7725)
  chore(deps): update dependency supertokens-node to v13.1.2 (redwoodjs#7714)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jtoar jtoar

Labels
fixture-ok Override the test project fixture check release:breaking This PR is a breaking change
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thedavidprice @jtoar